Refactored Auctions index

app/controllers/AuctionsController.scala

@@ -3,13 +3,13 @@ package controllers
 import actors.auctions.AuctionPublisher
 import controllers.authentication.AuthenticatedAction
 import dao.{AuctionsDAO, AuthTokensDAO}
-import models.Auction
+import models.AuctionStatus.Ready
+import models.{Auction, User}
 import org.apache.pekko.actor.typed.ActorRef
 import play.api.libs.functional.syntax.toFunctionalBuilderOps
-import play.api.libs.json.{JsError, JsPath, JsValue, Json, Reads, Writes}
+import play.api.libs.json.*
 import play.api.mvc.{BaseController, ControllerComponents}
 
-import java.security.SecureRandom
 import javax.inject.{Inject, Singleton}
 import scala.concurrent.{ExecutionContext, Future}
 
@@ -20,7 +20,7 @@ class AuctionsController @Inject()(val controllerComponents: ControllerComponent
                                    authenticatedAction: AuthenticatedAction,
                                    val auctionPublisher: ActorRef[AuctionPublisher.Command],
                                    implicit val ec: ExecutionContext) extends BaseController {
-  def index = authenticatedAction.async { implicit request =>
+  def index = authenticatedAction.async { request =>
     for {
       auctions <- auctionsDAO.list_available(request.user)
       json = Json.toJson(auctions)
@@ -35,15 +35,13 @@ class AuctionsController @Inject()(val controllerComponents: ControllerComponent
         for {
           auction <- auctionsDAO.create(auctionCreateData.name, auctionCreateData.startingPrice, request.user)
           json = Json.toJson(auction)
-          response = Created(json)
           _ = auctionPublisher ! AuctionPublisher.Publish(auction, request.user)
-        } yield response
+        } yield Created(json)
       }
     )
   }
 
   private case class AuctionCreateData(name: String, startingPrice: BigDecimal)
-  private implicit val auctionCreateDataReads: Reads[AuctionCreateData] = (
+
-    (JsPath \ "name").read[String] and (JsPath \ "starting_price").read[BigDecimal]
+  private given Reads[AuctionCreateData] = Json.reads[AuctionCreateData]
-  )(AuctionCreateData.apply)
 }

app/models/models.scala

@@ -1,6 +1,6 @@
 package models
 
-import play.api.libs.json.{JsValue, Json, Writes}
+import play.api.libs.json.{JsString, JsValue, Json, OWrites, Writes}
 
 import java.time.Instant
 
@@ -24,6 +24,8 @@ enum AuctionStatus(val value: Short) {
 
 object AuctionStatus {
   lazy val byValue: Map[Short, AuctionStatus] = Map.from(AuctionStatus.values.map{it => (it.value, it)})
+
+  implicit val writes: Writes[AuctionStatus] = (o: AuctionStatus) => JsString(o.toString)
 }
 
 case class Auction(id: Option[Int], name: String, status: AuctionStatus, gid: String, authorId: Int,
@@ -32,14 +34,5 @@ case class Auction(id: Option[Int], name: String, status: AuctionStatus, gid: St
                    createdAt: Instant)
 
 object Auction {
-  implicit val writes: Writes[Auction] = (a: Auction) => Json.obj(
+  implicit val writes: OWrites[Auction] = Json.writes[Auction]
-    "id" -> a.id,
-    "name" -> a.name,
-    "gid" -> a.gid,
-    "status" -> a.status.toString,
-    "starting_price" -> a.startingPrice,
-    "current_bid" -> a.currentBid,
-    "current_bidder_id" -> a.currentBidderId,
-    "current_bid_at" -> a.currentBidAt
-  )
 }