Sending actor data to MQTT

app/actors/auctions/AuctionPublisher.scala

@@ -4,25 +4,21 @@ import com.google.inject.Provides
 import com.hivemq.client.mqtt.datatypes.MqttQos
 import com.hivemq.client.mqtt.mqtt5.Mqtt5AsyncClient
 import com.hivemq.client.mqtt.mqtt5.message.publish.Mqtt5Publish
-import dao.AuctionsDAO
-import models.{Auction, AuctionStatus, User}
+import models.Auction
 import mqttClient.MqttClientFactory
-import org.apache.pekko.actor.typed.{ActorRef, Behavior}
+import org.apache.pekko.actor.typed.Behavior
 import org.apache.pekko.actor.typed.scaladsl.Behaviors
 import play.api.{Configuration, Logging}
 import play.api.libs.concurrent.ActorModule
-import play.api.libs.json.{JsBoolean, JsObject, JsValue, Json}
+import play.api.libs.json.Json
 
 import java.nio.charset.StandardCharsets
 import javax.inject.Singleton
-import scala.jdk.OptionConverters.RichOptional
-import scala.util.Random
 
 object AuctionPublisher extends ActorModule with Logging {
   sealed trait Command
   private case object Ready extends Command
-  case class Publish(auction: Auction, author: User) extends Command
-  private case class AuctionConfirmed(id: Long, responseTopic: String) extends Command
+  case class Publish(auction: Auction) extends Command
 
   private final val topic = "auctions/created"
 
@@ -30,74 +26,41 @@ object AuctionPublisher extends ActorModule with Logging {
 
   @Provides
   @Singleton
-  def apply(configuration: Configuration, auctionsDAO: AuctionsDAO): Behavior[Message] = Behaviors.setup { context =>
+  def apply(configuration: Configuration): Behavior[Message] = Behaviors.setup { context =>
     val client = MqttClientFactory.createClient(configuration, "-auction-publisher")
     client.connect().whenComplete { (_action, _throwable) =>
       context.self ! Ready
     }
 
-    idle(context.self, client, auctionsDAO)
+    idle(client)
   }
 
-  private def idle(self: ActorRef[Message], client: Mqtt5AsyncClient, auctionsDAO: AuctionsDAO, waitingPublishes: Seq[Publish] = List()): Behaviors.Receive[Command] = Behaviors.receiveMessage[Command] {
-    case p: Publish =>
-      idle(self, client, auctionsDAO, waitingPublishes :+ p)
+  private def idle(client: Mqtt5AsyncClient, waitingPublishes: Seq[Auction] = List()): Behaviors.Receive[Command] = Behaviors.receiveMessage[Command] {
+    case Publish(auction) =>
+      idle(client, waitingPublishes :+ auction)
     case Ready =>
-      for { publish <- waitingPublishes } publishAuction(client, publish.auction, publish.author, self)
-      ready(self, client, auctionsDAO)
-    case message @ AuctionConfirmed(_, _) =>
-      logger.warn(s"Received impossible message $message")
-      idle(self, client, auctionsDAO, waitingPublishes)
+      for { auction <- waitingPublishes } publishAuction(client, auction)
+      ready(client)
   }
 
-  private def ready(self: ActorRef[Message], client: Mqtt5AsyncClient, auctionsDAO: AuctionsDAO): Behaviors.Receive[Command] = Behaviors.receiveMessage[Command] {
-    case Publish(auction, author) =>
-      publishAuction(client, auction, author, self)
-      ready(self, client, auctionsDAO)
-    case AuctionConfirmed(auctionId, responseTopic) =>
-      client.unsubscribeWith().topicFilter(responseTopic).send()
-      auctionsDAO.changeStatus(auctionId, AuctionStatus.Ready)
-      ready(self, client, auctionsDAO)
+  private def ready(client: Mqtt5AsyncClient): Behaviors.Receive[Command] = Behaviors.receiveMessage[Command] {
+    case Publish(auction) =>
+      publishAuction(client, auction)
+      ready(client)
     case Ready =>
-      logger.warn("Message Ready received after having already received it before")
-      ready(self, client, auctionsDAO)
+      logger.warn("Message Ready received after ")
+      ready(client)
   }
 
-  private def publishAuction(client: Mqtt5AsyncClient, auction: Auction, author: User, self: ActorRef[Command]): Unit = {
-    val payload = Json.toBytes(auction_payload(auction, author))
-    val responseTopic = s"auction-validate/${auction.gid}-${Random.alphanumeric.take(8).mkString}"
-
-    client.subscribeWith()
-      .topicFilter(responseTopic)
-      .callback{ message =>
-        logger.info(s"Receiving message on ${message.getTopic}")
-        logger.info(message.getPayloadAsBytes.mkString("Array(", ", ", ")"))
-        message.getPayload.toScala
-          .map(StandardCharsets.UTF_8.decode(_).toString)
-          .map(Json.parse)
-          .flatMap(v => (v \ "ok").toOption)
-          .map{
-            case b: JsBoolean if b.value => self ! AuctionConfirmed(auction.id.get, responseTopic)
-              // TODO: add error handling
-          }
-      }
-      .send()
+  private def publishAuction(client: Mqtt5AsyncClient, auction: Auction): Unit = {
+    val payload = Json.toBytes(Json.toJson(auction))
 
     val publish = Mqtt5Publish.builder()
       .topic(topic)
       .payload(payload)
-      .responseTopic(responseTopic)
       .qos(MqttQos.EXACTLY_ONCE)
       .build()
     logger.info(s"Publishing auction ${auction.id.getOrElse(-1)}")
     client.publish(publish)
   }
-
-  private def auction_payload(auction: Auction, author: User): JsObject = {
-    Json.obj(
-      "gid" -> auction.gid,
-      "author_gid" -> author.gid,
-      "starting_price" -> auction.startingPrice
-    )
-  }
 }

app/controllers/AuctionsController.scala

@@ -3,43 +3,23 @@ package controllers
 import actors.auctions.AuctionPublisher
 import controllers.authentication.AuthenticatedAction
 import dao.{AuctionsDAO, AuthTokensDAO}
+import models.Auction
 import org.apache.pekko.actor.typed.ActorRef
-import play.api.libs.json.*
+import play.api.libs.functional.syntax.toFunctionalBuilderOps
+import play.api.libs.json.{JsError, JsPath, JsValue, Json, Reads, Writes}
 import play.api.mvc.{BaseController, ControllerComponents}
 
+import java.security.SecureRandom
 import javax.inject.{Inject, Singleton}
 import scala.concurrent.{ExecutionContext, Future}
-import models.Auction
-import caching.{CheckFresh, DigestEtagable, Etagable}
-
-import java.io.DataOutputStream
 
 @Singleton
 class AuctionsController @Inject()(val controllerComponents: ControllerComponents,
                                    val auctionsDAO: AuctionsDAO,
                                    val authTokensDAO: AuthTokensDAO,
-                                   authenticatedAction: AuthenticatedAction,
-                                   val auctionPublisher: ActorRef[AuctionPublisher.Command])
-                                  (implicit val ec: ExecutionContext)
-  extends BaseController with CheckFresh {
-  def index = authenticatedAction.async { request =>
-    for {
-      auctions <- auctionsDAO.list_available(request.user)
-      json = Json.toJson(auctions)
-    } yield Ok(json)
-  }
-
-  def show(id: Long) = authenticatedAction.async { implicit request =>
-    auctionsDAO.showAvailable(request.user, id).map { auctionOpt =>
-      auctionOpt.fold(NotFound) { auction =>
-        checkFresh(auction) {
-          Ok(Json.toJson(auction)).withHeaders("etag" -> auction.etag)
-        }
-      }
-    }
-  }
-
-  def create = authenticatedAction.async(parse.json) { implicit request =>
+                                   val auctionPublisher: ActorRef[AuctionPublisher.Command],
+                                   implicit val ec: ExecutionContext) extends BaseController {
+  def create = Action.andThen(AuthenticatedAction(authTokensDAO)).async(parse.json) { implicit request =>
     val auctionCreateDataResult = request.body.validate[AuctionCreateData]
     auctionCreateDataResult.fold(
       errors => Future.successful(BadRequest(JsError.toJson(errors))),
@@ -47,27 +27,15 @@ class AuctionsController @Inject()(val controllerComponents: ControllerComponent
         for {
           auction <- auctionsDAO.create(auctionCreateData.name, auctionCreateData.startingPrice, request.user)
           json = Json.toJson(auction)
-          _ = auctionPublisher ! AuctionPublisher.Publish(auction, request.user)
-        } yield Created(json)
+          response = Created(json)
+          _ = auctionPublisher ! AuctionPublisher.Publish(auction)
+        } yield response
       }
     )
   }
 
   private case class AuctionCreateData(name: String, startingPrice: BigDecimal)
-
-  private given Reads[AuctionCreateData] = Json.reads[AuctionCreateData]
-
-  private given DigestEtagable[Auction] with {
-    override protected def writeDigestData(a: Auction, s: DataOutputStream): Unit = {
-      s.writeLong(a.id.getOrElse(0))
-      s.writeLong(a.authorId)
-      s.writeUTF(a.gid)
-      s.writeUTF(a.name)
-      s.writeLong(a.createdAt.getEpochSecond)
-
-      s.writeLong(a.currentBidderId.getOrElse(0))
-      a.currentBid.foreach(b => s.writeLong((b * 1000).toLong))
-      a.currentBidAt.foreach(ba => s.writeLong(ba.getEpochSecond))
-    }
-  }
+  private implicit val auctionCreateDataReads: Reads[AuctionCreateData] = (
+    (JsPath \ "name").read[String] and (JsPath \ "starting_price").read[BigDecimal]
+  )(AuctionCreateData.apply)
 }

app/controllers/HomeController.scala

@@ -1,24 +1,15 @@
 package controllers
 
-import play.api.*
-import _root_.controllers.authentication.{AuthenticatedAction, AuthenticatedRequest}
-import _root_.controllers.caching.{CheckFresh, DigestEtagable}
-import models.User
-import play.api.libs.json.Json
-import play.api.mvc.*
-
-import java.io.DataOutputStream
-import java.nio.charset.StandardCharsets.UTF_8
-import javax.inject.*
+import javax.inject._
+import play.api._
+import play.api.mvc._
 
 /**
  * This controller creates an `Action` to handle HTTP requests to the
  * application's home page.
  */
 @Singleton
-class HomeController @Inject()(val controllerComponents: ControllerComponents,
-                               authenticatedAction: AuthenticatedAction)
-  extends BaseController with Logging with CheckFresh {
+class HomeController @Inject()(val controllerComponents: ControllerComponents) extends BaseController {
 
   /**
    * Create an Action to render an HTML page.
@@ -30,20 +21,4 @@ class HomeController @Inject()(val controllerComponents: ControllerComponents,
   def index() = Action { implicit request: Request[AnyContent] =>
     Ok(views.html.index())
   }
-
-  def userData = authenticatedAction { implicit request: AuthenticatedRequest[AnyContent] =>
-    val user = request.user
-    checkFresh(user) {
-      // TODO: put the max-age somewhere into config
-      Ok(Json.toJson(user)).withHeaders("Cache-Control" -> "private, max-age=15, must-revalidate")
-    }
-  }
-
-  private given DigestEtagable[models.User] with {
-    override protected def writeDigestData(a: User, s: DataOutputStream): Unit = {
-      s.writeLong(a.id.getOrElse(0))
-      s.write(a.gid.getBytes(UTF_8))
-      s.write(a.username.getBytes(UTF_8))
-    }
-  }
 }

app/controllers/authentication/AuthenticatedAction.scala

@@ -5,15 +5,13 @@ import jakarta.inject.Inject
 import models.{AuthToken, User}
 import play.api.libs.json.*
 import play.api.mvc.Results.Unauthorized
-import play.api.mvc.{ActionBuilder, ActionRefiner, AnyContent, BodyParsers, Request, Result, WrappedRequest}
+import play.api.mvc.{ActionRefiner, Request, Result, WrappedRequest}
 
 import scala.concurrent.{ExecutionContext, Future}
 
 class AuthenticatedRequest[A](val token: AuthToken, val user: User, request: Request[A]) extends WrappedRequest[A](request)
 
-class AuthenticatedAction @Inject()(val parser: BodyParsers.Default, authTokensDao: AuthTokensDAO)(implicit val executionContext: ExecutionContext)
-  extends ActionRefiner[Request, AuthenticatedRequest]
-  with ActionBuilder[AuthenticatedRequest, AnyContent]{
+class AuthenticatedAction @Inject()(authTokensDao: AuthTokensDAO)(implicit val executionContext: ExecutionContext) extends ActionRefiner[Request, AuthenticatedRequest] {
   override protected def refine[A](request: Request[A]): Future[Either[Result, AuthenticatedRequest[A]]] = {
     val authHeader = request.headers.get("Authorization")
       .map(_.split(" ", 2)(1))
@@ -37,4 +35,5 @@ class AuthenticatedAction @Inject()(val parser: BodyParsers.Default, authTokensD
       case None => unauthenticatedRequestError
     }
   }
+
 }

app/controllers/authentication/SessionsController.scala

@@ -9,45 +9,39 @@ import play.api.mvc.{AbstractController, ControllerComponents}
 
 import scala.concurrent.{ExecutionContext, Future}
 
-object SessionsController {
 case class LoginData(username: String, password: String)
-  given Reads[LoginData] = Json.reads[LoginData]
-}
+implicit val loginDataReads: Reads[LoginData] = (
+  (JsPath \ "username").read[String] and
+    (JsPath \ "password").read[String]
+)(LoginData.apply)
+implicit val tokenWrites: Writes[AuthToken] = (token: AuthToken) => Json.obj(
+  "token" -> token.token,
+  "createdAt" -> token.createdAt,
+  "expiresAt" -> token.expiresAt
+)
 
 
 @Singleton
-class SessionsController @Inject()(
-                                    controllerComponents: ControllerComponents,
-                                    usersDAO: UsersDAO,
-                                    authTokensDAO: AuthTokensDAO,
-                                    authenticatedAction: AuthenticatedAction)
-                                  (implicit val ec: ExecutionContext)
-  extends AbstractController(controllerComponents) {
-  import SessionsController.{LoginData, given}
-
+class SessionsController @Inject()(controllerComponents: ControllerComponents, usersDAO: UsersDAO, authTokensDAO: AuthTokensDAO, implicit val ec: ExecutionContext) extends AbstractController(controllerComponents) {
   def login() = Action.async(parse.json) { implicit request =>
     val loginDataResult = request.body.validate[LoginData]
     loginDataResult.fold(
-      errors => Future.successful(BadRequest(JsError.toJson(errors))),
+      errors => {
+        Future.successful(BadRequest(Json.obj("message" -> JsError.toJson(errors))))
+      },
       loginData => {
         usersDAO.authenticate(loginData.username, loginData.password).flatMap { userOption =>
           userOption.fold(
             Future.successful(UnprocessableEntity(Json.obj("message" -> "Invalid authentication")))
           ){ user =>
-            authTokensDAO.createToken(user).map { token =>
-              val json = Json.toJsObject(token) ++ Json.obj(
-                "userId" -> user.id.get,
-                "userGid" -> user.gid
-              )
-              Ok(json)
-            }
+            authTokensDAO.createToken(user).map(token => Ok(Json.toJson(token)))
           }
         }
       }
     )
   }
 
-  def logout = authenticatedAction.async { request =>
+  def logout = Action.andThen(new AuthenticatedAction(authTokensDAO)).async { request =>
     authTokensDAO.destroy(request.token).map{ _ => Ok("") }
   }
 }

app/controllers/caching/caching.scala

@@ -1,57 +0,0 @@
-package controllers.caching
-
-import play.api.mvc.Results.NotModified
-import play.api.mvc.{Request, Result}
-
-import java.io.{ByteArrayOutputStream, DataOutputStream, OutputStream}
-import java.security.{DigestOutputStream, MessageDigest}
-import java.util.Base64
-import scala.concurrent.{ExecutionContext, Future}
-import scala.util.Using
-
-trait Etagable[A]:
-  extension (a: A) def etag: String
-
-
-trait DigestEtagable[A] extends Etagable[A]:
-  private val base64 = Base64.getUrlEncoder.withoutPadding
-
-  protected def writeDigestData(a: A, s: DataOutputStream): Unit
-
-  extension (a: A) {
-    override def etag: String = {
-      val md = MessageDigest.getInstance("SHA-1")
-      Using(DataOutputStream(DigestOutputStream(OutputStream.nullOutputStream(), md))) { dos =>
-        writeDigestData(a, dos)
-        dos.flush()
-      }
-
-      base64.encodeToString(md.digest())
-    }
-  }
-
-
-trait CheckFresh {
-  protected def checkFreshAsync[A, E: Etagable](entity: E)(onStale: => Future[Result])(using request: Request[A], ec: ExecutionContext): Future[Result] = {
-    compareEtag(request, entity).fold(
-      entityEtag => onStale.map(_.withHeaders("etag" -> entityEtag)),
-      requestEtag => Future.successful(notModified(requestEtag))
-    )
-  }
-
-  protected def checkFresh[A, E: Etagable](entity: E)(onStale: => Result)(using request: Request[A]): Result = {
-    compareEtag(request, entity).fold(
-      entityEtag => onStale.withHeaders("etag" -> entityEtag),
-      requestEtag => notModified(requestEtag)
-    )
-  }
-
-  private def compareEtag[A, E: Etagable](request: Request[A], entity: E) = {
-    val entityEtag = entity.etag
-    request.headers.get("If-None-Match").filter(e => e == entityEtag) match {
-      case Some(etag) => Right(etag)
-      case None => Left(entityEtag)
-    }
-  }
-  private def notModified(etag: String) = NotModified.withHeaders("etag" -> etag)
-}

app/controllers/devel/DevActionsController.scala

@@ -1,32 +0,0 @@
-package controllers.devel
-
-import dao.UsersDAO
-import play.api.libs.functional.syntax.toFunctionalBuilderOps
-import play.api.libs.json.{JsError, JsPath, Json, Reads}
-import play.api.mvc.*
-
-import javax.inject.Inject
-import scala.concurrent.{ExecutionContext, Future}
-
-class DevActionsController @Inject()(val controllerComponents: ControllerComponents,
-                                     val usersDAO: UsersDAO)
-                                    (implicit val ec: ExecutionContext)
-  extends BaseController {
-
-  private case class UserData(username: String, password: String)
-  private implicit val userDataReads: Reads[UserData] = (
-    (JsPath \ "username").read[String] and (JsPath \ "password").read[String]
-  )(UserData.apply)
-
-  def createUser = Action.async(parse.json) { implicit request =>
-    request.body.validate[UserData].fold(
-      errors => Future.successful(BadRequest(JsError.toJson(errors))),
-      userData => usersDAO.create(userData.username, userData.password)
-        .map {
-          case Left(UsersDAO.UsernameTaken) => BadRequest(Json.obj("error" -> "Username exists"))
-          case Left(_ex) => BadRequest(Json.obj("error" -> "User creation error"))
-          case Right(user) => Ok(Json.toJson(user))
-        }
-    )
-  }
-}

app/controllers/devel/DevRouter.scala

@@ -1,24 +0,0 @@
-package controllers.devel
-
-import play.api.Environment
-import play.api.Mode.Dev
-import play.api.mvc.*
-import play.api.routing.Router.Routes
-import play.api.routing.SimpleRouter
-import play.api.routing.sird.{POST, UrlContext}
-
-import javax.inject.Inject
-
-class DevRouter @Inject()(environment: Environment, controller: DevActionsController) extends SimpleRouter {
-  override def routes: Routes = {
-    if (environment.mode == Dev) {
-      devRoutes
-    } else {
-      PartialFunction.empty
-    }
-  }
-
-  private val devRoutes: PartialFunction[RequestHeader, Handler] = {
-    case POST(p"/users") => controller.createUser()
-  }
-}

app/controllers/filters/LoggingFilter.scala

@@ -17,7 +17,7 @@ class LoggingFilter @Inject()(implicit val mat: Materializer, ec: ExecutionConte
       val endTime = System.currentTimeMillis()
       val requestTime = endTime - startTime
 
-      logger.info(s"${requestHeader.method} ${requestHeader.uri} ${result.header.status} ${requestTime}ms")
+      logger.info(s"${requestHeader.method} ${requestHeader.uri} ${result.header.status} $requestTime")
 
       result
     }

app/dao/AuctionsDAO.scala

@@ -1,39 +1,23 @@
 package dao
 
+import models.Auction
+import schemas.Auctions
 import play.api.db.slick.{DatabaseConfigProvider, HasDatabaseConfigProvider}
 import slick.jdbc.PostgresProfile
 import slick.jdbc.PostgresProfile.api.*
+import utils.Random
+
 import java.time.Instant
 import javax.inject.Inject
 import scala.concurrent.{ExecutionContext, Future}
-import scala.util.Random
-
-import models.{Auction, AuctionStatus, User}
-import schemas.Auctions
-import schemas.given
 
 class AuctionsDAO @Inject()(protected val dbConfigProvider: DatabaseConfigProvider)(implicit val ec: ExecutionContext)
   extends HasDatabaseConfigProvider[PostgresProfile] {
 
-  def list_available(user: User): Future[Seq[Auction]] = {
-    db.run(availableScope(user).result)
-  }
-
-  def showAvailable(user: User, id: Long): Future[Option[Auction]] = {
-    db.run {
-      availableScope(user).filter(_.id === id).take(1).result.headOption
-    }
-  }
-
-  def list_created_by(user: User): Future[Seq[Auction]] = {
-    db.run(Auctions.filter(_.authorId === user.id).result)
-  }
-
-  def create(name: String, startingPrice: BigDecimal, author: User): Future[Auction] = {
+  def create(name: String, startingPrice: BigDecimal, author: models.User): Future[Auction] = {
     val auction = Auction(
       id = None, name = name,
-      gid = Random.alphanumeric.take(24).mkString,
-      status = AuctionStatus.Created,
+      gid = Random.randomBase64(24),
       authorId = author.id.get,
       startingPrice = startingPrice,
       currentBid = None, currentBidderId = None, currentBidAt = None,
@@ -46,26 +30,4 @@ class AuctionsDAO @Inject()(protected val dbConfigProvider: DatabaseConfigProvid
   def create(auction: Auction) : Future[Auction] = {
     db.run((Auctions returning Auctions) += auction)
   }
-
-  def changeStatus(auctionId: Long, status: AuctionStatus): Future[Boolean] = {
-    db.run(Auctions.filter(_.id === auctionId).map(_.status).update(status))
-      .map(_ == 1)
-  }
-
-  def find_by_gid(gid: String): Future[Option[Auction]] = {
-    db.run(Auctions.filter(_.gid === gid).take(1).result.headOption)
-  }
-
-  def newBid(auction: Auction, bidder: User, bid: BigDecimal, timestamp: Instant): Future[Option[Auction]] = {
-    db.run {
-      Auctions.filter(_.id === auction.id.get).map{ it => (it.currentBid, it.currentBidAt, it.currentBidderId) }
-        .update((Some(bid), Some(timestamp), Some(bidder.id.get)))
-        .andThen { Auctions.filter(_.id === auction.id.get).result.headOption }
-        .transactionally
-    }
-  }
-
-  private def availableScope(user: User) = {
-    Auctions.filter(row => (row.status === AuctionStatus.Ready) && (row.authorId =!= user.id.get))
-  }
 }

app/dao/AuthTokensDAO.scala

@@ -12,9 +12,9 @@ import java.time.{Duration, Instant}
 import scala.concurrent.{ExecutionContext, Future}
 import models.AuthToken
 import schemas.AuthTokens
+import utils.Random
 
 import scala.language.postfixOps
-import scala.util.Random
 
 class AuthTokensDAO @Inject()(protected val dbConfigProvider: DatabaseConfigProvider)(implicit val ec: ExecutionContext) extends HasDatabaseConfigProvider[PostgresProfile] {
   private final lazy val tokenValidDuration = Duration.ofDays(30)
@@ -28,7 +28,7 @@ class AuthTokensDAO @Inject()(protected val dbConfigProvider: DatabaseConfigProv
     val token = AuthToken(
       id = None,
       userId = user.id.get,
-      token = Random.alphanumeric.take(12).mkString,
+      token = Random.randomBase64(12),
       createdAt = Instant.now,
       expiresAt = Instant.now.plus(tokenValidDuration)
     )

app/dao/UsersDAO.scala

@@ -1,6 +1,5 @@
 package dao
 
-import dao.UsersDAO.{UnexpectedError, UsernameTaken}
 import de.mkammerer.argon2.Argon2Factory
 import execution.CryptoExecutionContext
 import jakarta.inject.Inject
@@ -10,74 +9,23 @@ import slick.jdbc.PostgresProfile.api.*
 
 import scala.concurrent.{ExecutionContext, Future}
 import models.User
-import org.postgresql.util.{PSQLException, PSQLState}
 import schemas.Users
 
-import java.nio.charset.StandardCharsets.UTF_8
-import scala.util.Random
-
-class UsersDAO @Inject()(protected val dbConfigProvider: DatabaseConfigProvider, private val cryptoEC: CryptoExecutionContext)
-                        (using ec: ExecutionContext)
+class UsersDAO @Inject()(protected val dbConfigProvider: DatabaseConfigProvider, private val cryptoEC: CryptoExecutionContext)(implicit val ec: ExecutionContext)
   extends HasDatabaseConfigProvider[PostgresProfile] {
   private val argon2 = Argon2Factory.create()
 
-  private object ArgonParameters {
-    val iterations = 3
-    val parallelism = 1
-    val memory = 65536
-  }
-
-  private final val dummyDigest = "$argon2i$v=19$m=65536,t=3,p=1$EB9QibLwzqkO7ne2bJoU/Q$ADkdyweXKylJORvWXbBVekURYaazkW/OplTq2wdN1So"
-
   def authenticate(username: String, password: String): Future[Option[User]] = {
     val query = Users.filter(_.username === username).take(1).result.headOption
+
     val userFuture = db.run(query)
 
     userFuture.map { userOption =>
       for {
         user <- userOption
         digest <- user.passwordDigest
-      } yield (user, digest)
-    }.map {
-        case Some((user, digest)) => (Some(user), digest)
-        case None => (None, dummyDigest)
-    }.flatMap { (userOpt, digest) =>
-      for {
-        validHash <- Future(argon2.verify(digest, password.getBytes(UTF_8)))(using cryptoEC)
-        opt = userOpt.flatMap(u => if validHash then Some(u) else None)
-      } yield opt
+        if argon2.verify(digest, password.getBytes("UTF-8"))
+      } yield user
+    }(using cryptoEC)
   }
 }
-
-  def create(username: String, password: String): Future[Either[UsersDAO.RegistrationError, User]] = {
-    Future(argonHash(password))(using cryptoEC)
-      .flatMap{ passwordDigest =>
-        val gid = Random.alphanumeric.take(12).mkString
-        val user = User(
-          id = None,
-          gid = gid,
-          username = username,
-          passwordDigest = Some(passwordDigest)
-        )
-
-        db.run((Users returning Users) += user).map(Right(_))
-      }.recover {
-        case ex: PSQLException if ex.getSQLState == PSQLState.UNIQUE_VIOLATION.getState =>
-          Left(UsernameTaken)
-        case ex: Throwable =>
-          Left(UnexpectedError(ex))
-      }
-  }
-
-  def find_by_gid(gid: String): Future[Option[User]] = {
-    db.run(Users.filter(_.gid === gid).take(1).result.headOption)
-  }
-
-  private def argonHash(data: String) = argon2.hash(ArgonParameters.iterations, ArgonParameters.memory, ArgonParameters.parallelism, data.getBytes(UTF_8))
-}
-
-object UsersDAO {
-  sealed trait RegistrationError
-  case object UsernameTaken extends RegistrationError
-  case class UnexpectedError(cause: Throwable) extends RegistrationError
-}

app/models/models.scala

@@ -1,44 +1,26 @@
 package models
 
-import play.api.libs.json.{JsString, JsValue, Json, OWrites, Writes}
+import play.api.libs.json.{JsValue, Json, Writes}
 
 import java.time.Instant
 
-case class User(id: Option[Long], username: String, gid: String, passwordDigest: Option[String])
-object User {
-  given writes: Writes[User] = (o: User) => Json.obj(
-    "gid" -> o.gid,
-    "username" -> o.username
-  )
-}
+case class User(id: Option[Int], username: String, gid: String, passwordDigest: Option[String])
 
-case class AuthToken(id: Option[Long], userId: Long, token: String, createdAt: Instant, expiresAt: Instant)
-object AuthToken {
-  given writes: OWrites[AuthToken] = (a: AuthToken) => Json.obj(
-    "token" -> a.token,
-    "userId" -> a.userId,
-    "createdAt" -> a.createdAt,
-    "expiresAt" -> a.expiresAt
-  )
-}
+case class AuthToken(id: Option[Int], userId: Int, token: String, createdAt: Instant, expiresAt: Instant)
 
-enum AuctionStatus(val value: Short) {
-  case Created extends AuctionStatus(0)
-  case Ready extends AuctionStatus(10)
-  case Finished extends AuctionStatus(10000)
-}
-
-object AuctionStatus {
-  lazy val byValue: Map[Short, AuctionStatus] = Map.from(AuctionStatus.values.map{it => (it.value, it)})
-
-  implicit val writes: Writes[AuctionStatus] = (o: AuctionStatus) => JsString(o.toString)
-}
-
-case class Auction(id: Option[Long], name: String, status: AuctionStatus, gid: String, authorId: Long,
+case class Auction(id: Option[Int], name: String, gid: String, authorId: Int,
                    startingPrice: BigDecimal, currentBid: Option[BigDecimal],
-                   currentBidderId: Option[Long], currentBidAt: Option[Instant],
+                   currentBidderId: Option[Int], currentBidAt: Option[Instant],
                    createdAt: Instant)
 
 object Auction {
-  implicit val writes: OWrites[Auction] = Json.writes[Auction]
+  implicit val writes: Writes[Auction] = (a: Auction) => Json.obj(
+    "id" -> a.id,
+    "name" -> a.name,
+    "gid" -> a.gid,
+    "starting_price" -> a.startingPrice,
+    "current_bid" -> a.currentBid,
+    "current_bidder_id" -> a.currentBidderId,
+    "current_bid_at" -> a.currentBidAt
+  )
 }

app/mqttClient/MessageProcessorActor.scala

@@ -8,10 +8,8 @@ import org.apache.pekko.actor.typed.{ActorRef, Behavior}
 import org.apache.pekko.actor.typed.scaladsl.Behaviors
 import play.api.Logging
 import play.api.libs.concurrent.ActorModule
-import play.api.libs.json._
 
 import java.nio.charset.StandardCharsets
-import scala.util.matching.Regex
 
 object MessageProcessorActor extends ActorModule with Logging {
   sealed trait Command
@@ -20,16 +18,14 @@ object MessageProcessorActor extends ActorModule with Logging {
 
   override type Message = Command
 
-  private final val newBidPattern: Regex = """notify/new_bid/(\w+)""".r
-
   @Singleton
   class Reg @Inject()(private val mqttMessageProcessorActor: ActorRef[Command])
 
   @Provides
-  def create(client: Mqtt5AsyncClient, newBidService: services.auctions.NewBid): Behavior[Command] = Behaviors.setup { context =>
+  def create(client: Mqtt5AsyncClient): Behavior[Command] = Behaviors.setup { context =>
     client.connect().whenComplete { (_action, _throwable) =>
       client.subscribeWith()
-        .topicFilter("notify/new_bid/+")
+        .topicFilter("test/+")
         .callback{ (publish) =>
           context.self ! MqttMessageReceived(publish)
         }
@@ -41,17 +37,6 @@ object MessageProcessorActor extends ActorModule with Logging {
         val topic = publish.getTopic
         val payload = String(publish.getPayloadAsBytes, StandardCharsets.UTF_8)
         logger.info(s"Received message $topic $payload")
-
-        topic.toString match {
-          case newBidPattern(auctionGid) =>
-            Json.parse(payload).validate[services.auctions.NewBid.Request] match {
-              case JsSuccess(request, _) => newBidService.perform(auctionGid, request)
-              case JsError(errors) =>
-                logger.warn(errors.toString())
-            }
-            println(s"New bid $auctionGid")
-        }
-
         Behaviors.same
       case Stop => Behaviors.stopped{ () =>
         client.disconnect()

app/schemas/schemas.scala

@@ -8,7 +8,7 @@ import slick.model.ForeignKeyAction.{Cascade, Restrict}
 import java.time.Instant
 
 class UsersTable(tag: Tag) extends Table[User](tag, "users") {
-  def id = column[Long]("id", O.PrimaryKey, O.AutoInc)
+  def id = column[Int]("id", O.PrimaryKey, O.AutoInc)
   def gid = column[String]("gid", O.Unique)
   def username = column[String]("username", O.Unique)
   def passwordDigest = column[Option[String]]("password_digest")
@@ -20,8 +20,8 @@ lazy val Users = TableQuery[UsersTable]
 
 class AuthTokensTable(tag: Tag) extends Table[AuthToken](tag, "auth_tokens") {
 
-  def id = column[Long]("id", O.PrimaryKey, O.AutoInc)
-  def userId = column[Long]("user_id")
+  def id = column[Int]("id", O.PrimaryKey, O.AutoInc)
+  def userId = column[Int]("user_id")
   def token = column[String]("token")
   def createdAt = column[Instant]("created_at")
   def expiresAt = column[Instant]("expires_at")
@@ -33,25 +33,18 @@ class AuthTokensTable(tag: Tag) extends Table[AuthToken](tag, "auth_tokens") {
 
 lazy val AuthTokens = TableQuery[AuthTokensTable]
 
-implicit val auctionStatusColumnType: BaseColumnType[AuctionStatus] =
-  MappedColumnType.base[AuctionStatus, Short](
-    enumValue => enumValue.value,
-    intValue => AuctionStatus.byValue(intValue)
-  )
-
 class AuctionsTable(tag: Tag) extends Table[Auction](tag, "auctions") {
-  def id = column[Long]("id", O.PrimaryKey, O.AutoInc)
+  def id = column[Int]("id", O.PrimaryKey, O.AutoInc)
   def name = column[String]("name")
-  def status = column[AuctionStatus]("status")
   def gid = column[String]("gid", O.Unique)
-  def authorId = column[Long]("author_id")
-  def startingPrice = column[BigDecimal]("starting_price", O.SqlType("DECIMAL(20, 3)"))
-  def currentBid = column[Option[BigDecimal]]("current_bid", O.SqlType("DECIMAL(20, 3)"))
-  def currentBidderId = column[Option[Long]]("current_bidder_id")
+  def authorId = column[Int]("author_id")
+  def startingPrice = column[BigDecimal]("starting_price")
+  def currentBid = column[Option[BigDecimal]]("current_bid")
+  def currentBidderId = column[Option[Int]]("current_bidder_id")
   def currentBidAt = column[Option[Instant]]("current_bid_at")
   def createdAt = column[Instant]("created_at")
 
-  override def * : ProvenShape[Auction] = (id.?, name, status, gid, authorId, startingPrice, currentBid, currentBidderId, currentBidAt, createdAt).mapTo[Auction]
+  override def * : ProvenShape[Auction] = (id.?, name, gid, authorId, startingPrice, currentBid, currentBidderId, currentBidAt, createdAt).mapTo[Auction]
 
   def author = foreignKey("users", authorId, Users)(_.id, onDelete = Restrict)
 }

app/services/auctions/NewBid.scala

@@ -1,39 +0,0 @@
-package services.auctions
-
-import dao.{AuctionsDAO, UsersDAO}
-import models.Auction
-import play.api.libs.functional.syntax.toFunctionalBuilderOps
-import play.api.libs.json.{JsPath, JsResult, Reads}
-
-import java.time.Instant
-import javax.inject.Inject
-import scala.concurrent.{ExecutionContext, Future}
-
-object NewBid {
-  case class Request(bid: BigDecimal, bidderGid: String, timestamp: Instant)
-
-  given Reads[Request] = (
-    (JsPath \ "bid").read[BigDecimal] and
-      (JsPath \ "bidder_gid").read[String] and
-      (JsPath \ "timestamp").read[Instant]
-    )(Request.apply)
-}
-
-class NewBid @Inject()(auctionsDao: AuctionsDAO, usersDAO: UsersDAO)(using ec: ExecutionContext) {
-  import NewBid.Request
-
-  def perform(auctionGid: String, request: Request): Future[Option[Auction]] = {
-    val dataFuture = for {
-      auction <- auctionsDao.find_by_gid(auctionGid)
-      bidder <- usersDAO.find_by_gid(request.bidderGid)
-    } yield (auction, bidder)
-
-    dataFuture.flatMap {
-      case (Some(auction), Some(bidder)) =>
-        auctionsDao.newBid(auction, bidder, bid = request.bid, timestamp = request.timestamp)
-      case (_, _) =>
-        // One of them (or both) aren't found
-        Future.successful(None)
-    }
-  }
-}

app/utils/Random.scala

@@ -0,0 +1,16 @@
+package utils
+
+import java.nio.ByteBuffer
+import java.security.SecureRandom
+import java.util.Base64
+
+object Random {
+  private lazy val random = SecureRandom()
+  private lazy val base64 = Base64.getEncoder
+  
+  def randomBase64(bytes: Int): String = {
+    val tokenRaw = ByteBuffer.allocate(bytes)
+    random.nextBytes(tokenRaw.array())
+    base64.encodeToString(tokenRaw.array())
+  }
+}

compose.yaml

@@ -1,6 +1,4 @@
 name: 'neon-vertigo-api'
-include:
-  - ../shared/compose.shared.yml
 services:
   db:
     image: "postgres:18"
@@ -8,8 +6,3 @@ services:
       - db.env
     ports:
       - "5432:5432"
-    volumes:
-      - "db:/var/lib/postgresql"
-
-volumes:
-  db:

conf/application.conf

@@ -2,14 +2,9 @@
 
 play.http.filters=controllers.filters.Filters
 
-play.filters.enabled += "play.filters.cors.CORSFilter"
 play.filters.csrf.header.bypassHeaders {
     X-Requested-With = "*"
 }
-play.filters.cors {
-    allowedOrigins = ["http://localhost:4321"]
-    exposedHeaders = ["ETag"]
-}
 
 play.modules.enabled += "mqttClient.Module"
 

conf/evolutions/default/4.sql

@@ -1,7 +0,0 @@
--- !Ups
-ALTER TABLE auctions
-ADD COLUMN status SMALLINT NOT NULL DEFAULT 0;
-
--- !Downs
-ALTER TABLE auctions
-DROP COLUMN status;

conf/routes

@@ -9,13 +9,7 @@ GET     /                           controllers.HomeController.index()
 POST    /login                      controllers.authentication.SessionsController.login()
 DELETE  /logout                     controllers.authentication.SessionsController.logout()
 
-GET /user_data                      controllers.HomeController.userData()
-
 # Map static resources from the /public folder to the /assets URL path
 GET     /assets/*file               controllers.Assets.versioned(path="/public", file: Asset)
 
-GET     /auctions                   controllers.AuctionsController.index()
-GET     /auctions/:id               controllers.AuctionsController.show(id: Long)
 POST    /auctions                   controllers.AuctionsController.create()
-
--> /-devel                          controllers.devel.DevRouter